paper-swatch-picker icon indicating copy to clipboard operation
paper-swatch-picker copied to clipboard

Defer paper-item creation to first open for enormous performance improvement

Open aletorrado opened this issue 5 years ago • 2 comments

Hi, I've noticed a big performance penalty just by having about 20 paper-swatch-picker on a single page.

After research, it seems related to paper-item initialization, so I just deferred the paper-item creation to the first open event.

Previously there was a very similar strategy in place, probably for performance reasons as well, where the styling was applied on the first open event, so the change that was made is pretty simple.

aletorrado avatar Jul 07 '19 15:07 aletorrado

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 07 '19 15:07 googlebot

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 07 '19 16:07 googlebot