paper-slider icon indicating copy to clipboard operation
paper-slider copied to clipboard

disabled state at min value has some issues

Open opus1269 opened this issue 9 years ago • 1 comments

The following CSS selector is not being applied when at the minimum value:

.disabled.ring > #sliderKnob > #sliderKnobInner { background-color: transparent; }

This results in the background-color being set by the previous rule in the file. If I change it to something like this, it does work:

background-color: var(--paper-slider-disabled-knob-color, transparent);

The other issue in this selector is that it does not deal with the border of the knob. It's not easy to see with the default border color but if you use the --paper-slider-knob-start-border-color style you can see it is left as is when disabled. There is not a corresponding disabled style for this.

Also, it should be "grayed out" when disabled if the --paper-slider-knob-start-color is set but it should be transparent if the default transparent style is used.

One final general issue: The active portion of the slider and the knob are being set to a different shade of gray than the rest of the slider when disabled. It looks to me like the spec. wants the entire slider to be the same disabled color.

https://www.google.com/design/spec/components/sliders.html#sliders-continuous-slider

opus1269 avatar Oct 01 '15 08:10 opus1269

I think you right. That'd be a good enhancement.

blasten avatar Oct 05 '15 19:10 blasten