paper-slider icon indicating copy to clipboard operation
paper-slider copied to clipboard

Knob mixin

Open edu-aguilar opened this issue 8 years ago • 5 comments

added needed mixins to style the component from outside.

edu-aguilar avatar Jan 30 '17 09:01 edu-aguilar

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Jan 30 '17 09:01 googlebot

I signed in cla.developers.google

edu-aguilar avatar Jan 30 '17 10:01 edu-aguilar

CLAs look good, thanks!

googlebot avatar Jan 30 '17 10:01 googlebot

Hi @edu-aguilar , can you give some use cases on how these mixins will be used? Adding unnecessary mixins to the implementation of an element defeats the purpose of encapsulating implementation details.

keanulee avatar Jan 30 '17 20:01 keanulee

hi @keanulee first of all, thanks for your fast reply. Im working in a component that wraps this one and i need those mixins to apply styles from outside. Specially, to remove margins that I dont need and set a custom height and width to knob.

I think this could be useful for other devs =)

Thanks!

edu-aguilar avatar Feb 02 '17 12:02 edu-aguilar