Unexpected callback trigger from paper-toast

[hankphung]

Description

The paper-toast element placed inside paper-dialog trigger on-iron-overlay-closed callback on when dismissed.

Expected outcome

This should not be triggered.

Actual outcome

Dialog on-iron-overlay-closed callback got triggered

Steps to reproduce

1. Put a paper-toast element inside a paper-dialog.
2. Add on-iron-overlay-closed callback on paper-dialog with console.log.
3. Open the paper-dialog.
4. Trigger the toast to show.
5. Observe message from console.log.

Browsers Affected

• [X] Chrome
• [X] Firefox

//below not tested

• [ ] Safari 9
• [ ] Safari 8
• [ ] Safari 7
• [ ] Edge
• [ ] IE 11
• [ ] IE 10

[florent1933]

I think I have a problem related to your issue : https://github.com/PolymerElements/paper-dialog/issues/135

[valdrinkoshi]

These events (iron-overlay-opened, iron-overlay-closed) are bubbling by design, and changing this would be a breaking change. You can observe the event's root target to see who fired it, e.g.

onOverlayClosed: function(event) {
  var target = Polymer.dom(event).rootTarget;
  if (target.localName === 'paper-dialog') {
    // do things

[florent1933]

@valdrinkoshi 👍

Thank you so much! This is a good workaround.