paper-dialog-behavior icon indicating copy to clipboard operation
paper-dialog-behavior copied to clipboard

Import of typography.html overrides any --paper-font-common-base mixin set

Open KeithHenry opened this issue 8 years ago • 1 comments

paper-dialog-behavior imports ../paper-styles/typography.html:

https://github.com/PolymerElements/paper-dialog-behavior/blob/768729d22677442a833a2403df08173aa2a339dd/paper-dialog-shared-styles.html#L14

This will cause any --paper-font-common-base mixin that is already set to be overridden with the typography.

Instead paper-dialog-behavior should not re-import typography.html, but it should include a comment similar to paper-radio-button's approach:

/*
This element applies the mixin `--paper-font-common-base` but does not import `paper-styles/typography.html`.
In order to apply the `Roboto` font to this element, make sure you've imported `paper-styles/typography.html`.
*/

See also this issue on paper-styles, this issue against paper-input and this SO question.

KeithHenry avatar Oct 30 '17 07:10 KeithHenry

Paper elements should have consistency over --paper-font-common-base. I'd vote for paper-radio-button's approach as @KeithHenry suggested.

renfeng avatar Oct 30 '17 11:10 renfeng