paper-card icon indicating copy to clipboard operation
paper-card copied to clipboard

Expose sizing and position properties from iron-image (update)

Open matthewpull opened this issue 8 years ago • 3 comments

Fixes #60

PR #62 also fixes this issue, but is a year old. This PR is an attempt to gain traction on fixing the issue and includes the two test cases required.

This is my first PR :tada:, so if I have made a rookie mistake or missed anything please let me know and I'll fix my error.

Cheers!

matthewpull avatar Jan 24 '17 20:01 matthewpull

Omg, finally looking at this. Sorry about that! @bicknellr for a double check, but this looks okay to me.

notwaldorf avatar Aug 31 '17 19:08 notwaldorf

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot avatar Aug 31 '17 19:08 googlebot

Is this going to get merged anytime soon?

Pupix avatar Jan 31 '19 11:01 Pupix