neon-animation icon indicating copy to clipboard operation
neon-animation copied to clipboard

Importing neon-animation into a page that already uses web animations polyfill causes breaking errors

Open madeleineostoja opened this issue 8 years ago • 3 comments

Including neon-animation.html into a page that already has a web animations polyfill loaded causes breaking errors (cannot read property 'cancel' of null).

Removing the web-animations.html import from neon-animation fixes the problem. Should neon-animation check if features are available before importing a polyfill?

Minimal repro: https://jsbin.com/tutonabali/edit?html,js,console,output

EDIT: seems to only error on Chrome.

madeleineostoja avatar Jun 11 '16 23:06 madeleineostoja

I can't see the issue in your repro, but this sounds like this issue which was fixed in 2.2.1

dstoc avatar Jun 20 '16 00:06 dstoc

Hmm repro is still erroring for me:

error

Assume the Polygit import there is at least 2.2.1?

Chrome 51.0.2704.103 on OSX

madeleineostoja avatar Jun 24 '16 09:06 madeleineostoja

Looks like this is caused by https://github.com/web-animations/web-animations-js/issues/88

madeleineostoja avatar Oct 11 '16 06:10 madeleineostoja