iron-test-helpers icon indicating copy to clipboard operation
iron-test-helpers copied to clipboard
verified publisher icon PolymerElements

Fix MockInteractions.track to provide correct step values

Open txsmith opened this issue 9 years ago • 4 comments

Fixes #59, the delta computations in the move function were the wrong way around.

Also get rid of the setTimeout call in the test suite since polymer/polymer#3540 is resolved

txsmith avatar Jun 27 '16 21:06 txsmith

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Jun 27 '16 21:06 googlebot

I signed it!

txsmith avatar Jun 27 '16 22:06 txsmith

CLAs look good, thanks!

googlebot avatar Jun 27 '16 22:06 googlebot

Could you give an indication on whether this is likely to be accepted in the near future?

txsmith avatar Feb 20 '17 08:02 txsmith