iron-menu-behavior icon indicating copy to clipboard operation
iron-menu-behavior copied to clipboard

'Esc' key unexpectedly propagates to parent nodes.

Open freshp86 opened this issue 9 years ago • 4 comments

See repro at https://jsfiddle.net/no958fqr/.

This is causing problems, for example when a paper-dropdown-menu resides within a dialog. Hitting the 'esc' key when the dropdown menu is focused should only close the dropdown menu, but not the dialog. This is affecting Chrome's new Settings page, see https://bugs.chromium.org/p/chromium/issues/detail?id=638518.

/cc @danbeam

freshp86 avatar Sep 14 '16 21:09 freshp86

/cc @bicknellr @notwaldorf

danbeam avatar Sep 15 '16 00:09 danbeam

@tjsavage

danbeam avatar Sep 20 '16 01:09 danbeam

@valdrinkoshi Is this already addressed by the fix for PolymerElements/iron-overlay-behavior#212?

JanMiksovsky avatar Sep 21 '16 18:09 JanMiksovsky

No, this is different, as the request is to have the overlay stop the event's propagation. @freshp86 @danbeam iron-overlay-behavior already provides the event iron-overlay-canceled which detail is the source event. You could listen to that event and stop the propagation yourself too event.detail.stopPropagation()

valdrinkoshi avatar Sep 21 '16 18:09 valdrinkoshi