iron-component-page icon indicating copy to clipboard operation
iron-component-page copied to clipboard

master branch is hard-coded

Open tomalec opened this issue 9 years ago • 1 comments

Description

iron-component-page has "master" branch name hard-coded therefore it's impossible to use it with any other branch.

Expected outcome

iron-component-page should be able to render component page regardless of branch name

Actual outcome

No documentation found.

is shown

Live Demo

http://puppetjs.github.io/puppet-polymer-client/

Steps to reproduce

  1. Create custom-element as any other.
  2. Use branch anything.
  3. Open http://yourorganization.github.io/custom-element/.

Browsers Affected

  • [x] Chrome
  • [x] Firefox
  • [x] Safari 9
  • [x] Safari 8
  • [x] Safari 7
  • [x] Edge
  • [x] IE 11
  • [x] IE 10

tomalec avatar Jun 07 '16 14:06 tomalec

@justinfagnani Could you take a look? All checks are passing for PR https://github.com/PolymerElements/iron-component-page/pull/102. I think the fix is quite non-intrusive. But issue makes iron-component-page useless to quite many (at least our) custom elements.

tomalec avatar Jun 28 '16 12:06 tomalec