iron-autogrow-textarea icon indicating copy to clipboard operation
iron-autogrow-textarea copied to clipboard

Published 20 hours ago • verified publisher icon PolymerElements

fix: on-change event in shadowRoot

Open alimd opened this issue 6 years ago • 7 comments

As you know, In the Shadow DOM, the change event is not leaked into the ancestor tree, so we must do this manually. This is done in the rest of the input components by paper-input-behavior.

Fixed https://github.com/PolymerElements/paper-input/issues/664

alimd avatar Jul 10 '18 08:07 alimd

@notwaldorf We have an issue in our app and need to fix it as soon as possible Could you please review/merge this PR with priority Thank you in advance.

alimd avatar Jul 10 '18 08:07 alimd

travis error is not related to this PR changes!

alimd avatar Jul 10 '18 08:07 alimd

The travis error is actually related to this PR: it says `Typings are stale. Please run "npm run update-types". You've added a new event type, which needs to be typed :)

Please update the types, then this should be good to merge

notwaldorf avatar Jul 17 '18 18:07 notwaldorf

@notwaldorf Oops! Excuse me.

alimd avatar Aug 07 '18 10:08 alimd

Why issue remains?!

alimd avatar Aug 07 '18 11:08 alimd

@notwaldorf I fix the generated declaration manually, but could you please check this issue for future PR?

My generated declaration interface IronAutogrowTextareaElement extends Polymer.IronValidatableBehavior, Polymer.IronControlState, Polymer.LegacyElementMixin, HTMLElement {

Travise interface IronAutogrowTextareaElement extends Polymer.Element, Polymer.IronValidatableBehavior, Polymer.IronControlState {

https://travis-ci.org/PolymerElements/iron-autogrow-textarea/builds/413055027?utm_source=github_status&utm_medium=notification

alimd avatar Aug 07 '18 11:08 alimd

cc @bicknellr for a release

notwaldorf avatar Aug 13 '18 19:08 notwaldorf