generator-polymer-init-custom-build icon indicating copy to clipboard operation
generator-polymer-init-custom-build copied to clipboard

No updated tag since before `splitHtml` refactor

Open jsilvermist opened this issue 8 years ago • 4 comments

@abdonrd @FredKSchott The latest tag for this is 2.0.1, which as @johnlim noted in #74 doesn't contain any of the updated syntax as long ago as the splitHtml refactor from PolymerProject to polymer-build.

This should be tagged with the current commits, as well as probably updating the polymer-starter-kit submodule commit, as this is still pointing to a commit from January 9th.

jsilvermist avatar May 25 '17 04:05 jsilvermist

Good catch, I'll create a new release

FredKSchott avatar May 25 '17 17:05 FredKSchott

released as v2.1.0, anything else needed for psk?

FredKSchott avatar May 25 '17 17:05 FredKSchott

@FredKSchott Well the commit it's pulling in for the psk is only missing several cleanups compared to the latest tagged version, but the PSK for Polymer 1 itself hasn't been tagged since before updating dependencies, and renaming sourceGlobs and includeDependencies to sources and extraDependencies.

(Full diff of current commit custom-build is pointing to vs master)

Also, the submodule linking to the psk would need to be updated to point to the latest release by:

$ cd generators/app/polymer-starter-kit/
$ git checkout <commit>
$ cd ..
$ git commit -v polymer-starter-kit/

Note: I can send a PR to update the submodule to a new commit if you don't want to checkout these repos, just tell me which commit to point it to. (Maybe tagging a new PSK 2,x release)

jsilvermist avatar May 25 '17 21:05 jsilvermist

We probably update the Custom Build after https://github.com/PolymerElements/polymer-starter-kit/issues/1035.

abdonrd avatar Jun 12 '17 08:06 abdonrd