app-route icon indicating copy to clipboard operation
app-route copied to clipboard

Fix documentation error location.pushState

Open elonmallin opened this issue 8 years ago • 3 comments

Documentation says window.location.pushState but the correct path should be window.history.pushState. (Noticed the guidelines says there should be an issue for each pull request but I'm already here and didn't create an issue for it nor found one)

elonmallin avatar Jan 16 '17 14:01 elonmallin

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Jan 16 '17 14:01 googlebot

Signed it. With two emails, one should be the same that I use on github.

elonmallin avatar Jan 16 '17 15:01 elonmallin

CLAs look good, thanks!

googlebot avatar Jan 16 '17 15:01 googlebot