app-pouchdb icon indicating copy to clipboard operation
app-pouchdb copied to clipboard

fix adapter and revslimit options when creating a new db

Open kasperstorgaard opened this issue 8 years ago • 3 comments

When creating a db, it seems that the adapter and revsLimit options have been switched, leading to wrong values when using either.

https://github.com/PolymerElements/app-pouchdb/blob/c06d7f0175c8c148e876247d67e81707ad807f3b/app-pouchdb-database-behavior.html#L60

...
db: {
  type: Object,
    computed: '__computeDb(dbName, adapter, revsLimit)',
    notify: true
  }
}
...

https://github.com/PolymerElements/app-pouchdb/blob/c06d7f0175c8c148e876247d67e81707ad807f3b/app-pouchdb-database-behavior.html#L230

...
__computeDb: function(name, revsLimit, adapter) {
...

kasperstorgaard avatar Jun 12 '17 22:06 kasperstorgaard

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot avatar Jun 12 '17 22:06 googlebot

I signed it!

kasperstorgaard avatar Jun 12 '17 22:06 kasperstorgaard

CLAs look good, thanks!

googlebot avatar Jun 12 '17 22:06 googlebot