app-localize-behavior
app-localize-behavior copied to clipboard
PolymerElements
added ability to change language of all app-localize-behavior instances
I think this is starting to look good! Left a bunch of nits and some questions
The PR needs a rebase, and review comments haven't been addressed, so it cannot be merged in its current state
Sorry to say the reason I haven't been able to finalize this is that I can't get the commit squashing correct. Every time I try the result is not what I expect.
Ah it's ok, you can ignore the squashing then -- I'll just do it from the merge options if that's easier :) On Wed, Oct 19, 2016 at 7:49 PM Mark Volkmann [email protected] wrote:
Sorry to say the reason I haven't been able to finalize this is that I can't get the commit squashing correct. Every time I try the result is not what I expect.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/PolymerElements/app-localize-behavior/pull/44#issuecomment-254905940, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTkUka5Jv5unKQbYOw90urbxQ99ixeXks5q1mYugaJpZM4Jc08m .
That would be great. Thanks Monica!
R. Mark Volkmann Object Computing, Inc.
On Oct 20, 2016, at 3:20 AM, Monica Dinculescu [email protected] wrote:
Ah it's ok, you can ignore the squashing then -- I'll just do it from the merge options if that's easier :) On Wed, Oct 19, 2016 at 7:49 PM Mark Volkmann [email protected] wrote:
Sorry to say the reason I haven't been able to finalize this is that I can't get the commit squashing correct. Every time I try the result is not what I expect.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/PolymerElements/app-localize-behavior/pull/44#issuecomment-254905940, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTkUka5Jv5unKQbYOw90urbxQ99ixeXks5q1mYugaJpZM4Jc08m .
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@mvolkmann you still need to do a rebase and address the review comments, though :)
I thought I did address all the feedback. I just can't get the rebase to work correctly. Could you give that a shot? I'm fine with any changes you want to make to my pull request.
R. Mark Volkmann Object Computing, Inc.
On Oct 20, 2016, at 6:15 AM, Monica Dinculescu [email protected] wrote:
@mvolkmann you still need to do a rebase and address the review comments, though :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Hmm I left comments that you shouldn't fire 'language-changed' events explicitly, and you should just make the property be a notify property.