tools icon indicating copy to clipboard operation
tools copied to clipboard

polymer-build remove comments

Open ghost opened this issue 6 years ago • 3 comments

Currently the polymer build tool leaves all comments in. If the user specifies js: minify, I believe comments should be removed. This could be achieved here:

https://github.com/Polymer/tools/blob/1fe1c22bfb81ad9195c99fa31ac24c675d15700c/packages/build/src/js-transform.ts#L286

by passing {presets, plugins, comments: false}

ghost avatar Nov 08 '19 22:11 ghost

"minify"

jonapgar avatar Jan 03 '20 15:01 jonapgar

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 02 '21 17:01 stale[bot]

Even supplying bundle.stripComments on polymer.json doesn't actually strip comments away, at least on Polymer 1.0 projects. It's driving me nuts.

quackbarc avatar Mar 26 '24 07:03 quackbarc