TerraOverworldConfig icon indicating copy to clipboard operation
TerraOverworldConfig copied to clipboard

[Bug] Massive MSPT spikes when loading a pale garden

Open Biquaternions opened this issue 4 months ago • 2 comments

Steps to reproduce

  1. Create a server
  2. Find a terra:overworld/overworld/pale_garden
  3. Walk around the pale forest

Expected behavior

Loading the biome should not cause massive TPS drop.

Actual behavior

Looks like a ton of leaves generated immediately decay as soon as the biome is loaded, which causes a ton of block updates which in turn, also causes lag. Here's a spark report for reference. In this case, I did the test with clean server only with Terra and ViaVersion, so lag spikes are short but huge, so the background profiler is unable to fully pick it up. This spike is much more noticeable if there're plugins that listen to block updates. First-hand experience using GriefDefender, although should apply to WorldGuard, Lands, GriefPrevention, anything that listens to block updates as mentioned, turning those mspt spikes into a full massive tps drop.

Background profiler while visiting a pale garden: https://spark.lucko.me/Ab5e7nmqCu

Profiler with --only-ticks-over 30 flag: https://spark.lucko.me/Q2LkD7wsFa

Biquaternions avatar Sep 02 '25 16:09 Biquaternions

Leaf decay for Pale Garden trees and Jungle trees has been heavily mitigated in the 2.0 branch of the Overworld pack as 2.0 will eventually replace the current default 1.0 Overworld pack once it has been finalized.

DeathShadez avatar Sep 02 '25 16:09 DeathShadez

Nice, I'll keep an eye on that branch

Biquaternions avatar Sep 02 '25 18:09 Biquaternions