feat: add support for allay platform
Pull Request
Description
This PR add support for allay platform.
Changelog
- [x] Basic support
- [x] Block & item & biome mappings
- [ ] ~~Command delegation~~
- [x] Reloading support
- [ ] ~~Mapping generator~~
Checklist
Mandatory checks
- [ ] The base branch of this PR is an unreleased version branch (that has a
ver/prefix) or is a branch that is intended to be merged into a version branch. - [x] There are no already existing PRs that provide the same changes.
- [x] The PR is within the scope of Terra (i.e. is something a configurable terrain generator should be doing).
- [x] Changes follow the code style for this project.
- [x] I have read the
CONTRIBUTING.mddocument in the root of the git repository.
Types of changes
- [ ] Bug Fix
- [ ] Build system
- [ ] Documentation
- [x] New Feature
- [ ] Performance
- [ ] Refactoring
- [ ] Repository
- [ ] Revert
- [ ] Style
- [ ] Tests
- [ ] Translation
Compatibility
- [ ] Introduces a breaking change
- [ ] Introduces new functionality in a backwards compatible way.
- [ ] Introduces bug fixes
Documentation
- [x] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
Testing
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
Licensing
Looks good except for a few things:
- Are we excepting the TODOs to be done before merge?
- Is it possible to not use coding styles like 'var' for consistency with the rest of the code base?
- If Allay is trying to emulate minecraft (which it is) i'd recommend implementing the additional platform biome options using fabric as a reference see (https://github.com/PolyhedralDev/Terra/tree/master/platforms/mixin-common/src/main/java/com/dfsek/terra/mod/config) for consistency with other platforms.
Over all good work!
- All 'var' have been replaced with the explicit type
- I'm not going to implement the remaining two features (command, additional biome options) as they are a bit difficult to implement now c:. However, config pack reloading should be easy to be done and I will implement it.
Looks good except for a few things:
- Are we excepting the TODOs to be done before merge?
- Is it possible to not use coding styles like 'var' for consistency with the rest of the code base?
- If Allay is trying to emulate minecraft (which it is) i'd recommend implementing the additional platform biome options using fabric as a reference see (https://github.com/PolyhedralDev/Terra/tree/master/platforms/mixin-common/src/main/java/com/dfsek/terra/mod/config) for consistency with other platforms.
Over all good work!
* All 'var' have been replaced with the explicit type * I'm not going to implement the remaining two features (command, additional biome options) as they are a bit difficult to implement now c:. However, config pack reloading should be easy to be done and I will implement it.
Sounds good.
Is it possible to pin allay to a specific build instead of using the latest build for compiling?
Is it possible to pin allay to a specific build instead of using the latest build for compiling?
Yes, I already did this c:
Ah sorry my git window had not refreshed since commit 8a6ad95
Is there anything else that needs to be done?
No it will get merged in the next release cycle
should @smartcmd be added as a CODEOWNER for the allay platform?
Yes I think, we should also add @OakLoaf as a code owner for bukkit