Chatting
Chatting copied to clipboard
Polyfrost
Fixed Chat Peek warning with SkyHanni
Description
Currently, the Chatting mod warns the user if they are using SkyHanni's chat peek feature active and have disabled the feature in Chatting. This indicates that this behavior is not intended without giving the user the choice to use either feature.
~~This PR changes the logic to only warn if both mods have the feature enabled to indicate unintended behavior instead of forcing the user to disable SkyHanni's.~~ This PR removes the check entirely.
See related code at https://github.com/hannibal002/SkyHanni/blob/ff6dd291a0f89644508171e6b984295de20466ce/src/main/java/at/hannibal2/skyhanni/features/chat/ChatPeek.kt
How to test
If you use SkyHanni's chat peek without the PR, leave Chatting's chat peek disabled and see how the notification is displayed. ~~With the PR, you will not see a notification as long as the feature is not enabled in Chatting.~~ With the PR, this message does no longer exist.
Release Notes
Documentation
We might want to include the tutorial on how to open the settings for both mods in the popup warning, not sure
"break the other mod on purpose so users use my mod" doesn't sound like a strategy for community projects
"break the other mod on purpose so users use my mod" doesn't sound like a strategy for community projects
The rest of the mixins i can confirm were because of conflicts with chatting and the other mod’s features. i think what might’ve happened is someone saw those notifications but noticed it didn’t happen for skyhanni chat peek, and then reported it to us and we “fixed” it. however i think there’s also a chance that there is actually a conflict with chatting and skyhanni chat peek so someone should test that
