node-myanimelist icon indicating copy to clipboard operation
node-myanimelist copied to clipboard

Mismatch EntryRecommendations type

Open phineasla opened this issue 3 years ago • 1 comments

https://github.com/PolyMeilex/node-myanimelist/blob/567d96be09c476a6460b453fa52524cafec4e3a1/src/methods/jikan4/types.ts#L680

The entry property is an object, not an array: https://api.jikan.moe/v4/anime/43608/recommendations

Example:

{
  "data": [
    {
      "entry": {
        "mal_id": 38101,
        "url": "https://myanimelist.net/anime/38101/5-toubun_no_Hanayome",
        "images": {
          "jpg": {
            "image_url": "https://cdn.myanimelist.net/images/anime/1819/97947.jpg?s=63766d471cbb06b0bc8d4c81d5fc98fe",
            "small_image_url": "https://cdn.myanimelist.net/images/anime/1819/97947t.jpg?s=63766d471cbb06b0bc8d4c81d5fc98fe",
            "large_image_url": "https://cdn.myanimelist.net/images/anime/1819/97947l.jpg?s=63766d471cbb06b0bc8d4c81d5fc98fe"
          },
          "webp": {
            "image_url": "https://cdn.myanimelist.net/images/anime/1819/97947.webp?s=63766d471cbb06b0bc8d4c81d5fc98fe",
            "small_image_url": "https://cdn.myanimelist.net/images/anime/1819/97947t.webp?s=63766d471cbb06b0bc8d4c81d5fc98fe",
            "large_image_url": "https://cdn.myanimelist.net/images/anime/1819/97947l.webp?s=63766d471cbb06b0bc8d4c81d5fc98fe"
          }
        },
        "title": "5-toubun no Hanayome"
      },
      "url": "https://myanimelist.net/recommendations/anime/38101-43608",
      "votes": 1
    }
  ]
}

phineasla avatar May 26 '22 18:05 phineasla

Reported the bug in upstream model definition In the meantime, I will fix this locally on our side shortly.

Thanks for the report!

PolyMeilex avatar May 26 '22 19:05 PolyMeilex