Bartłomiej Maryńczak

Results 205 comments of Bartłomiej Maryńczak

Also pinging @meowtec any ideas why `windres` binary would be missing or couldn't be executed?

> Maybe we should remove the resource-build code and leave it to be done by the user of rfd. They can choose either [embed_resource](https://crates.io/crates/embed_resource) or [winres](https://crates.io/crates/winres) for embedding the manifest...

Hi! 1. Is this async dialog or sync one? 2. If it is sync, is there any threading involved? 3. Could you perhaps provide a full rust-gdb backtrace? That would...

`STATUS_HEAP_CORRUPTION` looks like Microsoft COM error, so I assume windows. Winit uses COM to handle it's drag and drop so we are probably having some races related to that. I...

`rust-gdb` should be available out of the box in rust toolchain. ``` 1. rust-gdb ./path/to/binary 2. type in `run` (or `r` for short) 3. reproduce the crash 4. type in...

I'm not sure what should be expected behavior in this case, should we panic at runtime instead? Failing at compile time is a clear indication to the dev that RFD...

Yep, indeed we can't be sure that zenity or kdialog is there, but then it's a case of lack of a fallback for a fallback, I don't care about such...

> The (Async)MessageDialog structs were only implemented on Linux with GTK. How do you plan to handle that? I would still suggest moving them to a separate library. I kinda...

Indeed, I think we can make it !Send !Sync, and if someone does not care about wasm and needs Send/Sync, they can just unwrap the file handle and use Path...

Yep it's very intentional because on wasm there is no concept of paths, you should just call read on the selected file, and therefore we needed an wrapper type that...