OxiSynth
OxiSynth copied to clipboard
impl std::error::Error for Error
Hey there!
First of all, want to say I'm glad I found a rust library that does SF2! Well done :)
Is it possible that the error type implements std::error::Error
? This makes interaction with other libraries way easier. I recommend using thiserror and I'd be willing to implement this and do a pull request?
Also, are you going to split off soundfont-rs into its own repo?
Hey!
I'm very aware of the Error situation right now, I just did not have enough motivation lately to define all possible errors that OxiSynth
can throw, and ()
was used as a placeholder (in some places &str
was used, which is obviously a terrible idea)
And yes, I also want to use thiserror
, it seems to be the best solution for a project of this scope.
Also, are you going to split off soundfont-rs into its own repo?
For now, I don't see a reason to do so, as OxiSynth
is probably the only consumer of it. But sure I'm open to split it anytime, if there is a need to. It was meant to be completely standalone anyways.
And thank you for your interest, I'm open to any suggestions.