Feature request: Add Left / Right hand information for pianos

[captainerd]

trafficstars

I would like to have this feature, Hand information: Right / Left for piano instruments.

Along side with displaying the tracks of the midi in the expected order since the piano is reversed, the last track is bass, the first is melody, so the bass should appear first then the melody.

I am not sure if done it correctly. a developer could review the code and suggest fixes or direct me in the right way to implement this feature i would appreciate it,

And thanks a lot for this AWESOME project !

[captainerd]

Well.. that's a headache to me with the design my only relevance to Rust is Tetanus and RD40.. , yesterday i tired it as buttons too and i didn't like it. But i will give it a try again on my day-off, maybe some sort of budge with hand icons would be nice.. ?

anyway, as i was crying on discord from yesterday it jumped notes in arpeggios or in series (when the same note comes less than 500ms as defined in source) so i spend my time now on that as it was more important to me

From my tests, i played "Ludovico experience" and "The River Flows In You" with a nice accuracy. take a look (/scene/playing_scene/midi_player.rs)

Cheers.. NeoThesiars !

[captainerd]

I've played a few songs, done some testing, everything seems fine now, u can dive in the code check things out

Thanks for the help

[captainerd]

            `  // make it relaxed, Lower Bound: 83% of the file's note duration, Upper Bound: 112% of the file's note duration.

            let lower_bound = duration.file_note_dur as f64 * 0.83;
            let upper_bound = duration.file_note_dur as f64 * 1.12;`
  I am not sure about this one, it seems way too relaxed, maybe make it a little more difficult (file-duration close) ? it is just that there isn't a single point were for a player mentally the note starts and ends (500ms) but if the player wants to learn to play the exact duration then he/she must make a mental -imagination- red line and always aim at the exact same point to start pressing and leaving the key..

playing some difficult songs suggests it should be moved up a little more, like 97% and 105%, ? thats kinda subjective..

[captainerd]

Hey as i am doing a gameplay on every compile i was thinking if i recall correctly the last synthesia used to freeze my waterfall while pressing the correct notes if i also pressed one wrong, it wouldn't accept the correct ones to let waterfall go either, forcing you to stop playing and press only the correct ones,

Its not a huge deal to me i am not fun of that, i don't know about others, it would be something to consider in the future if there are modes like 'melody, play along, auto' or if there are settings like 'Stop on mistakes'