Sokobot icon indicating copy to clipboard operation
Sokobot copied to clipboard

Added some optimization

Open mandar1jn opened this issue 5 years ago • 9 comments

In CommandEvent.java there were 2 if statements right after each other that were the same. And I switched some if statements to a switch statement (get it?)

mandar1jn avatar Nov 27 '20 12:11 mandar1jn

I love how this pull request has been up since 27 November and still hasn’t been merged/denied

mandar1jn avatar Mar 22 '21 13:03 mandar1jn

Lol

a-gt avatar Apr 01 '21 11:04 a-gt

@mandar1jn

I love how this pull request has been up since 27 November and still hasn’t been merged/denied

lol i just read this cant you just ask someone who commits to the repo

kk5dire avatar May 05 '21 21:05 kk5dire

@kk5dire nope. He doesn’t check his github. @PolyMarsDev Here. I pinged him. I bet he won’t do anything with this for another 2 years. Around 2 months ago I exposed him in a Q&A. He promised to go check out his github repositories. Well, I have pull requests in almost all of his repositories and none have been merged or denied

mandar1jn avatar May 06 '21 11:05 mandar1jn

I could merge them, however I do not maintain the public bots anymore and I am not sure what PolyMars would like to do with the code or if he would approve the merge. I will contact him to check this out.

AffluentAvo avatar May 06 '21 16:05 AffluentAvo

@AffluentAvo thanks!

mandar1jn avatar May 07 '21 17:05 mandar1jn

@T0biii ?

yes?

oh I got confused by the random issue mention, for some reason I thought it meant you mentioned an issue here

kk5dire avatar Jun 02 '21 10:06 kk5dire

@T0biii ?

yes?

oh I got confused by the random issue mention, for some reason I thought it meant you mentioned an issue here

in the Issue i mention this Pull Requests because of the erros he get. Because one commit here fixed the encoding for the MYSQL PW

T0biii avatar Jun 02 '21 10:06 T0biii

@T0biii ?

yes?

oh I got confused by the random issue mention, for some reason I thought it meant you mentioned an issue here

in the Issue i mention this Pull Requests because of the erros he get. Because one commit here fixed the encoding for the MYSQL PW

I fixed it not because it’s broken in the main repo, but because the program I used encoded it wrong.

mandar1jn avatar Jun 02 '21 13:06 mandar1jn