Polkadex icon indicating copy to clipboard operation
Polkadex copied to clipboard

Trading Fees, LMP and much more

Open Gauthamastro opened this issue 1 year ago • 2 comments

Issue ticket number and link

Closes https://github.com/Polkadex-Substrate/issue-tracker/issues/261

Checklist before requesting a review

  • [ ] I have performed a self-review of my code.
  • [ ] If it is a core feature, I have added thorough tests.
  • [x] I removed all Clippy and Formatting Warnings.
  • [x] I added required Copyrights.

Gauthamastro avatar Dec 01 '23 06:12 Gauthamastro

@serhii-temchenko @pavankanteti

@zktony will be testing and implementing the unit tests, resolving comments on this PR.

Gauthamastro avatar Dec 28 '23 03:12 Gauthamastro

resolves https://github.com/Polkadex-Substrate/issue-tracker/issues/268 and https://github.com/Polkadex-Substrate/issue-tracker/issues/267

Gauthamastro avatar Jan 24 '24 06:01 Gauthamastro

@serhii-temchenko Liquidity mining is enabled in this release. It will be a seperate release. You can ignore that for now.

Gauthamastro avatar Mar 05 '24 15:03 Gauthamastro

Codecov Report

Attention: Patch coverage is 44.90791% with 1017 lines in your changes are missing coverage. Please review.

Project coverage is 41.38%. Comparing base (ee7c18c) to head (039df27). Report is 1 commits behind head on Develop.

:exclamation: Current head 039df27 differs from pull request most recent head aabb855. Consider uploading reports for the commit aabb855 to get more accurate results

Files Patch % Lines
pallets/ocex/src/lib.rs 61.17% 238 Missing :warning:
pallets/ocex/src/validator.rs 25.87% 212 Missing :warning:
pallets/liquidity-mining/src/lib.rs 51.63% 148 Missing :warning:
pallets/ocex/src/lmp.rs 47.91% 100 Missing :warning:
pallets/ocex/rpc/src/lib.rs 0.00% 72 Missing :warning:
pallets/ocex/src/weights.rs 0.00% 61 Missing :warning:
pallets/liquidity-mining/src/callback.rs 50.56% 44 Missing :warning:
primitives/orderbook/src/types.rs 15.15% 28 Missing :warning:
pallets/ocex/src/benchmarking.rs 0.00% 18 Missing :warning:
pallets/thea-executor/src/weights.rs 0.00% 16 Missing :warning:
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #884      +/-   ##
===========================================
+ Coverage    39.39%   41.38%   +1.99%     
===========================================
  Files           63       67       +4     
  Lines         4094     5412    +1318     
===========================================
+ Hits          1613     2240     +627     
- Misses        2481     3172     +691     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 06 '24 05:03 codecov[bot]