RxBluetoothKit icon indicating copy to clipboard operation
RxBluetoothKit copied to clipboard

Updated RxSwift version to 6

Open simonbility opened this issue 4 years ago • 23 comments

simonbility avatar Jan 05 '21 16:01 simonbility

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 05 '21 16:01 CLAassistant

This seems harmless, could we get this merged soon ? ^^

bioche avatar Feb 02 '21 11:02 bioche

@freak4pc All Done!

Should i also run ./scripts/generate-docs.sh 7.0.0 ?

simonbility avatar Feb 10 '21 17:02 simonbility

I don't know that script too well but no harm in doing that, I guess :) Mainly interested in a compatibility release here.

freak4pc avatar Feb 10 '21 17:02 freak4pc

I also updated the docs now, i was going of the Instructions here

Thanks for taking care of this!

simonbility avatar Feb 10 '21 17:02 simonbility

Any chance we could get this merged soon? It looks like everythings ready to go to me?

cheif avatar Feb 16 '21 09:02 cheif

Any news on this 7.0.0 release ?

amaurydavid avatar Mar 01 '21 08:03 amaurydavid

Any reason why this is blocked? This blocking our migration to Xcode 12.5

eliekarouz avatar May 17 '21 15:05 eliekarouz

hey,

Is anybody here who could merge this PR? or provide an explanation why this PR was blocked and let us fix it. @freak4pc, @bartoszstelmaszuk

Thanks, Ilya

krezzoid avatar May 21 '21 12:05 krezzoid

Hey all, I'm not entirely sure why I'm being tagged. This repo is owned by Polidea and not RxSwiftCommunity. I have no admin or publishing rights on it and cannot assist with cutting a release, unfortunately.

freak4pc avatar May 22 '21 19:05 freak4pc

@freak4pc Well I'm pretty sure it's because you mentioned in earlier comment on this PR you would & I quote "merge & cut a new release" 😂

bioche avatar May 22 '21 19:05 bioche

Yup, I'm sorry. I'm managing about 30 different projects and repos :)

If something has "Rx" prefix to it there's a good chance I'm helping maintain it and thought this was the case here as well. I'm not too sure how I even go to this thread :P

Anyways, hope you'll work this out soon!

freak4pc avatar May 22 '21 19:05 freak4pc

hey @freak4pc

sorry, if I mentioned you by mistake, but I did it just because you told:

Let me know when that's done and I'll merge and cut a new release. https://github.com/Polidea/RxBluetoothKit/pull/392#pullrequestreview-587856994

so, my thoughts was that you should be able to merge this PR.

As I can see because of silence from Polidea side, repository owner, this PR have quite small chances to be merged.

Best regards, Ilya

krezzoid avatar May 24 '21 07:05 krezzoid

Well we probably won't have a response from Polidea soon given the company apparently doesn't exist anymore 😅https://www.linkedin.com/posts/polidea_polidea-was-acquired-by-snowflake-on-feb-activity-6764546785554817025-bgZq

bioche avatar May 24 '21 08:05 bioche

yep, I found the same news ;)

krezzoid avatar May 24 '21 08:05 krezzoid

So what's the recourse here? I see some of their other libraries have been updated more recently than this Feb 8 announcement. The Android and Flutter versions, for instance, have been updated as recently as this month.

Is there a dominant fork out there that has this PR merged? (it's hard to browse Github forks now)

tylerjames avatar May 26 '21 19:05 tylerjames

hey,

@dariuszseweryn, @mikolak as I can see you was able to merge PR to Android and Flutter versions of this library. Could you do the same for iOS version? or maybe you have a contacts from Polidea/Snowflake who can take care on it?

Thanks, Ilya

krezzoid avatar May 27 '21 06:05 krezzoid

May anyone tell me when this version will release?

outsbook avatar Jul 28 '21 14:07 outsbook

Sometime between now and never, it seems

tylerjames avatar Jul 28 '21 14:07 tylerjames

Hi @freak4pc, can we fork this under RxSwiftCommunity to maintain it there? I don't think they are going to work on this repo anymore.

eliekarouz avatar Sep 23 '21 14:09 eliekarouz

Again @eliekarouz

Hey all, I'm not entirely sure why I'm being tagged. This repo is owned by Polidea and not RxSwiftCommunity. I have no admin or publishing rights on it and cannot assist with cutting a release, unfortunately.

This is a Polidea project. They are not responsive to this thread and others, it seems.

I'm not feeling comfortable simply "grabbing" their code and making it a RxSwiftCommunity project. Also, I don't think we should maintain someone else's code this way unless they want to move it and manage it themselves.

freak4pc avatar Sep 23 '21 19:09 freak4pc

Did a bit of Googling. Polidea was acquired in Feb 2021 and are no longer offering software services, so I'm guessing that's the context for the lack of responses. The Android version of this project is still maintained, probably by an Android dev that still has access.

image

jfreeley avatar Oct 11 '21 17:10 jfreeley

This project is using Apache license. Nothing prevents anyone from forking and maintaining it.

I don't feel comfortable doing this with RxSwiftCommunity since we only host MIT-licensed projects.

freak4pc avatar Oct 11 '21 18:10 freak4pc

Im closing this issue. I dont have any hopes this will ever get merged.

I (or actually my employer) will keep the fork around but i would suggest to everyone relying on it to create their own fork, since my company has made no commitment to maintain this.

simonbility avatar Nov 17 '22 07:11 simonbility