policyengine-us icon indicating copy to clipboard operation
policyengine-us copied to clipboard

Consolidate the `aca_ptc` and `premium_tax_credit` variables

Open PavelMakarchuk opened this issue 9 months ago • 2 comments

They seem to represent the same value - I dont think both variables are necessary and I am unsure which to use

PavelMakarchuk avatar Feb 28 '25 13:02 PavelMakarchuk

It's aca_ptc, we're just keeping premium_tax_credit for continuity in case we have API users using the old name. If we have a way to issue a deprecation notice we can apply that, might be an API thing @anth-volk?

MaxGhenis avatar Feb 28 '25 14:02 MaxGhenis

Unfortunately, we don't have any deprecation feature in the API at the moment. About a year ago, Nikhil and I deprecated something in -uk and just had a printed message - probably not the most sustainable option.

Idea: Can we have a field in a country package (defined on Variable or Parameter via `-core), then consume it upstream?

anth-volk avatar Feb 28 '25 22:02 anth-volk