policyengine-us icon indicating copy to clipboard operation
policyengine-us copied to clipboard

California uprating doesn't work

Open MaxGhenis opened this issue 2 years ago • 2 comments

For example, the dependent exemption is uprated: https://github.com/PolicyEngine/policyengine-us/blob/ca967aba24271ed471c722ef3684b05e5502c034/policyengine_us/parameters/gov/states/ca/tax/income/exemptions/dependent_amount.yaml#L2-L12

But it doesn't work in the app: image

California CPI itself is uprated by the CBO CPI forecast:

https://github.com/PolicyEngine/policyengine-us/blob/ca967aba24271ed471c722ef3684b05e5502c034/policyengine_us/parameters/gov/states/ca/cpi.yaml#L2-L10

That works in the app, at least through 2029:

image

This seems like a uprating-chaining issue for core but logging here for now.

MaxGhenis avatar Mar 15 '24 12:03 MaxGhenis

@PavelMakarchuk verified this worked with a local test, but it's still broken in the web app:

image

MaxGhenis avatar Mar 15 '24 14:03 MaxGhenis

Right, my guess is we need to add some logic specifying ordering of uprating parameters; right now we just traverse the tree and apply in that order, irrespective of dependency.

nikhilwoodruff avatar Mar 18 '24 11:03 nikhilwoodruff

Filed https://github.com/PolicyEngine/policyengine-core/issues/292 for general uprating chaining

MaxGhenis avatar Oct 12 '24 14:10 MaxGhenis