policyengine-us icon indicating copy to clipboard operation
policyengine-us copied to clipboard

Rename `spm_unit_net_income` to `spm_resources`

Open SirMalamute opened this issue 1 year ago • 5 comments

Fixes #3707

copilot:all

SirMalamute avatar Jan 29 '24 03:01 SirMalamute

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.20%. Comparing base (05b2c02) to head (9206370). Report is 25 commits behind head on master.

:exclamation: Current head 9206370 differs from pull request most recent head ed8094c. Consider uploading reports for the commit ed8094c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3722      +/-   ##
==========================================
+ Coverage   99.16%   99.20%   +0.03%     
==========================================
  Files        2405     2405              
  Lines       34803    34803              
  Branches      163      163              
==========================================
+ Hits        34514    34526      +12     
+ Misses        259      247      -12     
  Partials       30       30              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 29 '24 03:01 codecov[bot]

@MaxGhenis or @nikhilwoodruff do you know why the added tests give the following error message: ValueError: Unexpected attributes in definition of variable "relative_income_change": 'requires_computation_after'

I am not familiar with the labor supply part

PavelMakarchuk avatar Feb 12 '24 21:02 PavelMakarchuk

@MaxGhenis or @nikhilwoodruff do you know why the added tests give the following error message: ValueError: Unexpected attributes in definition of variable "relative_income_change": 'requires_computation_after'

I am not familiar with the labor supply part

Seems like this is resolved?

MaxGhenis avatar Feb 12 '24 22:02 MaxGhenis

tests still failing

PavelMakarchuk avatar Mar 21 '24 16:03 PavelMakarchuk

@MaxGhenis we would need to make adjustments to the cps.py as well here right?

PavelMakarchuk avatar Apr 02 '24 00:04 PavelMakarchuk