IN county tax

[MattHJensen]

[MattHJensen]

@nikhilwoodruff, @MaxGhenis could you take a look at this implementation and let me know if I'm on the right track or would prefer that I head a different direction?

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.13%. Comparing base (cb92a56) to head (d7cab29). Report is 69 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1167   +/-   ##
=======================================
  Coverage   99.12%   99.13%           
=======================================
  Files        2592     2600    +8     
  Lines       37707    37794   +87     
  Branches      162      160    -2     
=======================================
+ Hits        37378    37466   +88     
+ Misses        297      296    -1     
  Partials       32       32           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[MattHJensen]

@nikhilwoodruff, thanks for the help above. I could use another tip on the versioning failure (also happening in #1168), and otherwise this is ready for review. cc @MaxGhenis

[nikhilwoodruff]

@nikhilwoodruff, thanks for the help above. I could use another tip on the versioning failure (also happening in #1168), and otherwise this is ready for review. cc @MaxGhenis

No problem - could you try pulling the master branch into this one? I just did that locally and there were some changes to the changelog that I think are needed (didn't want to mess up your local version).

[MattHJensen]

No problem - could you try pulling the master branch into this one? I just did that locally and there were some changes to the changelog that I think are needed (didn't want to mess up your local version).

That makes a lot of sense and of course worked. Thanks.

[MattHJensen]

@nikhilwoodruff and @MaxGhenis, this one is ready for review now. Thanks.

[MaxGhenis]

@PavelMakarchuk could you get this across the finish line? A la https://github.com/PolicyEngine/policyengine-us/blob/master/policyengine_us/variables/gov/states/md/tax/income/local/md_local_income_tax_before_credits.py

[PavelMakarchuk]

tests failing

fixed