policyengine-uk icon indicating copy to clipboard operation
policyengine-uk copied to clipboard

Published 20 hours ago • verified publisher icon PolicyEngine

Keep only adds or formula in household_benefits

Open MaxGhenis opened this issue 1 year ago • 3 comments

As required by new policyengine-core, this has a formula and adds

https://github.com/PolicyEngine/policyengine-uk/blob/b9f48c16e4d0ef76f175314a3a19aac56fd9fbfb/policyengine_uk/variables/household/income/benefit.py#L52

MaxGhenis avatar Feb 06 '24 17:02 MaxGhenis

Also

https://github.com/PolicyEngine/policyengine-uk/blob/b9f48c16e4d0ef76f175314a3a19aac56fd9fbfb/policyengine_uk/variables/gov/hmrc/tax.py#L14

anth-volk avatar Feb 09 '24 19:02 anth-volk

Let's use adds and reforms as needed. Switching to a formula would result in it not decomposing in the app. See https://github.com/PolicyEngine/policyengine-us/issues/3851

MaxGhenis avatar Feb 13 '24 16:02 MaxGhenis

See https://github.com/PolicyEngine/policyengine-us/pull/3972 for an example of a PR that applies reforms for these conditional lists

MaxGhenis avatar Feb 21 '24 05:02 MaxGhenis