Polaris icon indicating copy to clipboard operation
Polaris copied to clipboard

RUST Core Control Numerical Input Inputs String not Integer

Open ZVB334 opened this issue 4 years ago • 2 comments

Brief description of the issue

When clicking on the dial to set the field strength on the RUST core control, it doesn't actually set the value, meaning if you set it to a strength of 150, which should cover a 3x3 range, it still remains just a single tile of coverage. Unless if you set it by moving the dial setting.

What you expected to happen

Manually inputting 150 to set it to 150.

What actually happened

It remained at whatever default the value was.

Steps to reproduce

Open the Rust Core Control terminal and set the range to anything, notice how the range doesn't actually change.

Additional info:

Not as serious as the gyrotron issue when the RUST changes were first done, but a mild annoyance nonetheless.

ZVB334 avatar May 04 '21 20:05 ZVB334

That should be going through a text2num? https://github.com/PolarisSS13/Polaris/pull/8007/files#diff-34b7f3c8df59eef87801c1883fae87c6d9888fbebb783e09ca0533092796b236R30

			var/new_strength = params["str"]
			if(istext(new_strength))
				new_strength = text2num(new_strength)
			if(new_strength)
				G.set_beam_power(new_strength)```

Atermonera avatar May 08 '21 08:05 Atermonera

Not the gyrotron, the field setting for the core itself.

ZVB334 avatar May 08 '21 10:05 ZVB334