sprites icon indicating copy to clipboard operation
sprites copied to clipboard

feat: Add 8th generation gifs

Open andre23arruda opened this issue 3 years ago • 9 comments

Added 8th generation game pokémons gif: Folders:

  • animated/normal
  • animated/shiny

andre23arruda avatar Oct 26 '21 05:10 andre23arruda

Hello @andre23arruda, there shouldn't be a normal folder. All the normal sprites should reside in the animated/ folder.

Naramsim avatar Oct 26 '21 09:10 Naramsim

Moreover, our naming convention differs from the one you used. We name images with IDs, not with names. And back, female images need to be in the respective folders.

You can take a look at the existing folders to understand it better.

Naramsim avatar Oct 26 '21 09:10 Naramsim

Sorry for the confusion. I'll fix here and add female and back folders. Thanks for your contact

andre23arruda avatar Oct 26 '21 12:10 andre23arruda

Feel free to read https://github.com/PokeAPI/sprites/issues/59, which covers the very same thing you want to do. Better not to overlap and do the same thing twice.

Naramsim avatar Oct 26 '21 12:10 Naramsim

@andre23arruda are you still working on this pr? If not, let us know:)

devmike123 avatar Sep 22 '22 17:09 devmike123

Hello. How are you? So, I'm not working. To fix it, I need to change the name of all files :(

Atenciosamente, André Luiz Costa de Arruda Tel: (12) 982399873 CEP: 79370-000

[image: Mailtrack] https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11& Sender notified by Mailtrack https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11& 09/22/22, 02:01:37 PM

On Thu, Sep 22, 2022 at 1:20 PM Aniket Bhattacharjee < @.***> wrote:

@andre23arruda https://github.com/andre23arruda are you still working on this pr? If not, let us know:)

— Reply to this email directly, view it on GitHub https://github.com/PokeAPI/sprites/pull/60#issuecomment-1255323900, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH5WKMLZGN6JHPBO6MTOK3LV7SIMBANCNFSM5GW3NSHA . You are receiving this because you were mentioned.Message ID: @.***>

andre23arruda avatar Sep 22 '22 18:09 andre23arruda

Hmm, maybe we can transform all the files with a script. Something along the lines of https://github.com/PokeAPI/sprites/blob/master/scripts/renameSmogon.sh

I'll convert it to a draft

Naramsim avatar Sep 22 '22 20:09 Naramsim

Cool!! It can work

On Thu, Sep 22, 2022, 16:25 Alessandro Pezzè @.***> wrote:

Hmm, maybe we can transform all the files with a script. Something along the lines of https://github.com/PokeAPI/sprites/blob/master/scripts/renameSmogon.sh

I'll convert it to a draft

— Reply to this email directly, view it on GitHub https://github.com/PokeAPI/sprites/pull/60#issuecomment-1255513019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH5WKMPFX76VGHQ77QIKGYLV7S6FLANCNFSM5GW3NSHA . You are receiving this because you were mentioned.Message ID: @.***>

andre23arruda avatar Sep 22 '22 23:09 andre23arruda

Looking for contributors :)

devmike123 avatar Jan 02 '23 18:01 devmike123

this can be closed with #105

FallenDeity avatar Apr 23 '23 19:04 FallenDeity

Good to know, thanks

phalt avatar Apr 23 '23 20:04 phalt