sprites icon indicating copy to clipboard operation
sprites copied to clipboard

Add these famous icons of gen9 (Scarlet&Violet)

Open danimesq opened this issue 1 year ago • 3 comments

danimesq avatar Jan 06 '24 06:01 danimesq

@FallenDeity, what do you think about this?

danimesq avatar Jan 06 '24 19:01 danimesq

There are a few issues here you are not following the sprite conventions here

  • all sprites are mapped to their respective pokemon id like (Bulbasaur to 1.png) this mapping is used to generate the api data
  • The Big sprites are pretty redundant in my opinion and has no such precedent in the repository before the Small sprites seem fine
  • There seems to be a ton of white space around the icons those could perhaps be trimmed to compress the pngs and have a smaller size overall while maintaining aspect ratio (square)
  • There also seems to be a missing female directory for female icons the previous version icons included this.

That should be about it I suppose, lmk if you need any help 😄.

Also btw I am just a contributor don't have much power on which pr is accepted you might want to request @Naramsim or one of the other maintainers also for approval regarding the final PR.

FallenDeity avatar Jan 06 '24 20:01 FallenDeity

Hi! I cannot really review this PR since it's too large. By reading the comment of @FallenDeity I think the same way.

Naramsim avatar Jan 08 '24 12:01 Naramsim