pokebase icon indicating copy to clipboard operation
pokebase copied to clipboard

Inhance the CI publishing section

Open DahanDv opened this issue 1 year ago • 3 comments

@Naramsim Hi there. Once you guys figure out the Pypi bureaucracy, I'd like to propose changing the CI and automating the publishing process.

The CI will be split to 2 scenarios:

  1. Push. Any push to any branch will trigger all the testing suites. Same goes for non-master PRs.
  2. when a PR gets merged into master and only into master an automatic process will bump the version and execute the Pypi publish command.

Let me know if this sounds, and if it is, when we can start work on to :)

DahanDv avatar Dec 18 '23 16:12 DahanDv

Hi! @GregHilmes added the pokeapi account to his package, so I was able to publish 1.4.0, then 1.4.1 as well :)

We are ready! We can add a token in the secrets for publishing

Naramsim avatar Dec 20 '23 18:12 Naramsim

@Naramsim Great! I admit this will be the first time I'll implement such a process on GitHub's action platform, so it may take a few days to figure out, give or take, depending on other occupations I have. Let's keep this issue as a thread if I need anything from you guys :)

DahanDv avatar Dec 21 '23 12:12 DahanDv

Okok It'll be a learning experience!

I'll give you a thorough review 😁😁

Naramsim avatar Dec 21 '23 16:12 Naramsim