pokeapi icon indicating copy to clipboard operation
pokeapi copied to clipboard

Incorrect sprite URLs

Open marko-knoebl opened this issue 2 years ago • 5 comments

If I access

https://pokeapi.co/api/v2/pokemon/1

the value of sprites.front_default is:

https://raw.githubusercontent.com/PokeAPI/sprites/master/https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/1.png

  • which is not a valid image URL - a correct value would be:

https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/1.png

Looking at some code examples / demos that are using this API, they are all not showing images anymore at the moment

A couple of hours ago, images were still working for me

marko-knoebl avatar Jul 22 '22 11:07 marko-knoebl

Same here, i thought my code just blown up

mertthesamael avatar Jul 22 '22 11:07 mertthesamael

The moment I deployed my personal project this occurs haha, waiting for fixes.

igordeoliveira95 avatar Jul 22 '22 13:07 igordeoliveira95

Hi all, I'm really sorry for the problem. I rolled back and purged the Cloudflare cache. Thanks for raising the issue

Naramsim avatar Jul 22 '22 14:07 Naramsim

Thanks for the quick fix! Everything seems to be working again from my POV

marko-knoebl avatar Jul 23 '22 08:07 marko-knoebl

Hi, this isn't a fix, just a roll back. This is the PR (https://github.com/PokeAPI/pokeapi/pull/727) that broke the sprites.

I think we add the duplicated https://raw.githubusercontent.com/PokeAPI/sprites/master/ not in the build phase, but in Ditto or something. I'll investigate next Monday.

Naramsim avatar Jul 23 '22 19:07 Naramsim

Was this issue resolved in #745 @Naramsim?

C-Garza avatar Nov 11 '22 04:11 C-Garza

If I access

https://pokeapi.co/api/v2/pokemon/1

the value of sprites.front_default is:

https://raw.githubusercontent.com/PokeAPI/sprites/master/https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/1.png

  • which is not a valid image URL - a correct value would be:

https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/1.png

Looking at some code examples / demos that are using this API, they are all not showing images anymore at the moment

A couple of hours ago, images were still working for me

Not working

jayk-gupta avatar Jan 07 '23 14:01 jayk-gupta

Not true, I get https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/back/1.png which is valid

Naramsim avatar Jan 07 '23 16:01 Naramsim