pokeapi
pokeapi copied to clipboard
Corrected en-us growth rate names
Previously, the names for the erratic
and fluctuating
en-us growth rates were listed incorrectly.
Note that Language id 6 (German) also needs corrected by someone who speaks German.
Thanks for this PR. I see that the names have changed. Would you be so kind to open the same PR or better an issue over at veekun/pokedex
and check what the guys (@magical) say? Maybe the names we are currently using are for past generations.
If we end up accepting your contribution. Maybe it's worth changing the https://github.com/PokeAPI/pokeapi/blob/master/data/v2/csv/growth_rates.csv file as well. (And check the formulas to be still correct)
I created a pull request, but that repo appears unmaintained
Note that Language id 6 (German) also needs corrected by someone who speaks German.
Is this still required? I'd be happy to do that tomorrow?
@helblingjoel not required as of now. I'll ping you in the future if needed. Thanks a lot!
@helblingjoel I just merged the PR, if you like you could update the german names and open a new one
A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.
The staging branch will be deployed in our staging environment and you will be able to review the entire API.
A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.
You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).