pokeapi icon indicating copy to clipboard operation
pokeapi copied to clipboard

Mothim doesnt have any forms.

Open LuziferSenpai opened this issue 3 years ago • 14 comments

Hey,

I just found out that, mothim doesnt have the forms of the base pokemon, so why are there 2 listed?

It would be nice if they get removed.

LuziferSenpai avatar Mar 14 '21 17:03 LuziferSenpai

Those forms are present in Pokemon Go, not sure if they should be in this repository.

Naramsim avatar Mar 14 '21 21:03 Naramsim

They are not. I just looked it up and I dont find any entry to this. Only the female version has forms, not the male version.

LuziferSenpai avatar Mar 14 '21 21:03 LuziferSenpai

This is a full RESTful API linked to an extensive database detailing everything about the Pokémon main game series.

Not sure if this helps make the decision (and I know things have changed since 2013) but the original scope of this service was just the main game series.

Is Meltan part of this API? That might have already made the decision for us.

phalt avatar Mar 14 '21 22:03 phalt

This is a full RESTful API linked to an extensive database detailing everything about the Pokémon main game series.

Not sure if this helps make the decision (and I know things have changed since 2013) but the original scope of this service was just the main game series.

Is Meltan part of this API? That might have already made the decision for us.

Meltan is a pokemon from the main series since gen 8, its final evolution even has a gmax form ;)

LuziferSenpai avatar Mar 15 '21 00:03 LuziferSenpai

I don't know. Maybe it's better to remove those. I need to check out how they got in, anyway.

Naramsim avatar Mar 15 '21 19:03 Naramsim

They were added to the pokemon_forms.csv in this commit at Veekun and then this repo was updated in this commit.

C-Garza avatar Mar 16 '21 03:03 C-Garza

Thanks for the blame @C-Garza :smile: haha

If it's data coming directly from veekun I'd leave it here as well.

I just checked and the lines are still present. So we keep them.

Naramsim avatar Mar 16 '21 11:03 Naramsim

Huhh. Interesting. Are the other two forms identical? I wouldn't be opposed to getting rid of them. I feel like we've done that in the past. Similarly with Scatterbug and Spewpa.

magical avatar Mar 17 '21 05:03 magical

Hi Magical :) Good to see you :)

If you delete them, then we will do the same :) Just do it before merging that huge PR I'm seeing these days :smile:. That will be a pain here at PokeAPI

Naramsim avatar Mar 18 '21 08:03 Naramsim

Ha, well, if we do delete them it'll be after veekun/pokedex#327 is merged. (I don't want to create a bunch of unnecessary merge conflicts! 😅)

magical avatar Mar 19 '21 01:03 magical

Burmy still don't have the forms in the "varieties"

AskipLudo avatar Jan 05 '22 21:01 AskipLudo

We merged the data from Veekun. I don't know if the issue got resolved though.

Naramsim avatar Mar 29 '22 17:03 Naramsim

We merged the data from Veekun. I don't know if the issue got resolved though.

Hello, so burmy's forms are in the route https://pokeapi.co/api/v2/pokemon/412 (forms) but wormadam's forms are in the route https://pokeapi.co/api/v2/pokemon-species/413/ (varieties)

and in my projet I use the route of "pokemon-species" (varieties) to get all the Pokémon forms

AskipLudo avatar Apr 13 '22 13:04 AskipLudo

Then I'd consider this issue solved.

There is a why those are in a different endpoint for a reason, but I can't remember it In Veekun's issues it should be there somewhere.

Naramsim avatar Apr 14 '22 13:04 Naramsim