pokeapi icon indicating copy to clipboard operation
pokeapi copied to clipboard

Problem with item flag countable

Open Genschere opened this issue 1 year ago • 4 comments

Might be a minor thing but I wondered what the item flag (item_flags.csv) countable actually means. It seems hard to misunderstand but if it really means items that can have a count of how many there are, the data is quite bad on this. As example: all pokeballs are countable but berries are not. Actually most items that have a count in the games are not flagged as countable. I wonder if there is a special reason for it or if nobody bothered setting it because almost everything can have a count anyway. The only items that are non-countable are actually key and story items with special purpose like the bike.

Would it not make more sense to change this to a non-countable flag and only mark these "few" items with it? I know TMs are a bit more complicated on this since it depends on the generation if the item is unique or can have a count but since TMs are a bit special anyway this shouldn't be a reason to not correct this.

Genschere avatar Feb 24 '24 10:02 Genschere

IMO, the flag countable, or an counterflag uncountable, isnt needed, cause the non-countables should be base items, any other item is countable, with the exception of TMs between gen5-7 and HMs sofar they existed, but the data displays the most current data. one could make their counterability based upon categoric exclusion in code.

novadragonDOTspace avatar Feb 24 '24 16:02 novadragonDOTspace

True, but why does it even exist then? It could simply be removed.

Genschere avatar Feb 24 '24 22:02 Genschere

I muse, cause its an carryover from veekun/pokedex now outdated models

novadragonDOTspace avatar Feb 24 '24 22:02 novadragonDOTspace

Yep, most surely is an outdated model/piece of data. The prose says Has a count in the bag, so berries should be countable. And maybe every item, nowadays, but I don't know anything about gens past 3rd.

We could update the data and reflect the current real values, or flip the data.

Naramsim avatar Mar 01 '24 18:03 Naramsim