PojavLauncher icon indicating copy to clipboard operation
PojavLauncher copied to clipboard

[BUG] Issues with hidden swipeable buttons inside a drawer

Open Felix14-v2 opened this issue 2 years ago • 7 comments

Description

When you use swipeable button inside a drawer, it can be triggered by swiping from another button.

Demo/reproduction steps

https://github.com/PojavLauncherTeam/PojavLauncher/assets/75726196/0e86b0ca-7110-4527-9e0b-331203d0f428

Platform

- Device model: Tecno Pova 2 (Tecno LE7n)
- CPU architecture: x64
- Android version: 11
- PojavLauncher version: latest from actions

Anything else?

Since this function can be useful, I would be very happy to keep it, but as an option.

Felix14-v2 avatar Sep 24 '23 02:09 Felix14-v2

!!! Please, note: this bug is extremely useful for PvP/building controls: it allows us to create hidden areas that don't interfere with the normal gameplay (an area is not triggered by clicking on or swiping through it), however, they are triggered only when you move your finger through them while holding another triggering button. Using this we can create clear and convenient controls:

https://github.com/PojavLauncherTeam/PojavLauncher/assets/75726196/bfcd0416-a5f2-49e1-b502-cf679dad08b3

So, please, don't fix it until we have an alternative for that or don't fix at all :,)

Felix14-v2 avatar Sep 24 '23 23:09 Felix14-v2

Please, note: this bug is extremely useful for PvP/building controls: it allows us to create hidden areas that don't interfere with the normal gameplay (an area is not triggered by clicking on or swiping through it), however, they are triggered only when you move your finger through them while holding another triggering button. Using this we can create clear and convenient controls:

https://github.com/PojavLauncherTeam/PojavLauncher/assets/75726196/bfcd0416-a5f2-49e1-b502-cf679dad08b3

So, please, don't fix it until we have an alternative for that or don't fix at all :,)

I don't think this is a bug because it's very helpful when making controls.

According to your instructions, I think it is possible to add a new setting that lets you slide this item only for nearby buttons, or for the same group of buttons

MovTery avatar Sep 25 '23 03:09 MovTery

I don't think this is a bug

Then this feature has a bug: you have to open and close the drawer once each time you start the game to perform that trick, you can't just import a controlmap and use it without any additional actions. Such a bug inside a bug :)

a new setting ... only for nearby buttons

I think this will only restrict the possibilities. Actually the only inconvenience is when swipeable buttons from another drawer overlaps with the intended field. Example:

https://github.com/PojavLauncherTeam/PojavLauncher/assets/75726196/4db178ff-d2ab-43a3-94ea-e2a761e63302

Imo, if we want to save the feature and at the same time improve usability, we need a setting for drawers to determine which ones would be affected by this behaviour or not. This is the best solution for all related issues.

Felix14-v2 avatar Sep 25 '23 14:09 Felix14-v2

this should indeed be fixed.

Mathias-Boulay avatar Sep 25 '23 17:09 Mathias-Boulay

this should indeed be fixed.

😭 What about alteratives for the use case shown above? It will be a huge loss in functionality.

Felix14-v2 avatar Sep 25 '23 19:09 Felix14-v2

this should indeed be fixed.

😭 What about alteratives for the use case shown above? It will be a huge loss in functionality.

maybe you will be the only person that lost the functionality, in any case, you can always use an older version of pojav

GaucovyAero avatar Sep 26 '23 15:09 GaucovyAero

you will be the only person that lost the functionality

What do you mean? Inability to create a control layout with such a feature as shown above is an objective fact, unrelated to me or anyone else.

use an older version of pojav

You yourself understand that this is not an option.

Felix14-v2 avatar Sep 26 '23 16:09 Felix14-v2