Pointcept icon indicating copy to clipboard operation
Pointcept copied to clipboard

A minor code redundance in engine/test.py

Open preacherwhite opened this issue 1 year ago • 1 comments

in engines/test.py, under semsegtester, there is this snippet of code: for i in range(len(fragment_list)): # fragment_batch_size = 1

s_i, e_i = i * fragment_batch_size, min((i + 1) * fragment_batch_size, len(fragment_list)')

input_dict = collate_fn(fragment_list[s_i:e_i])

I found it to be quite redundant, since fragment batch size is always 1, why not simply do input_dict = collate_fn(fragment_list[i])?

preacherwhite avatar Oct 20 '24 03:10 preacherwhite

As code supports custom fragment_batch_size, but I manually block this function as not enough time to verify the accuracy.

Gofinge avatar Oct 21 '24 06:10 Gofinge