pcl icon indicating copy to clipboard operation
pcl copied to clipboard

Published 20 hours ago • verified publisher icon PointCloudLibrary

[openNURBS] Update optimizer workaround condition from upstream

Open WangWeiLin-MV opened this issue 1 year ago • 2 comments

Backport condition from upstream https://github.com/mcneel/opennurbs/blob/v8.12.24282.07001/opennurbs_lookup.cpp#L742-L743

Related

  • #5463
  • #6143

WangWeiLin-MV avatar Oct 17 '24 05:10 WangWeiLin-MV

Hi, so the main difference is that with this PR, there is no upper MSVC version for which optimizations are not turned off any more. On the one hand this is reasonable because we do not actually know right now when the problem will be fixed in MSVC, but on the other hand we would have to remember to come back to this file and set the upper version in the future. @larshg Thoughts?

mvieth avatar Oct 17 '24 08:10 mvieth

I don't have any strong opinion - but I think I would just leave it as is. Then we at least get "reminders" whenever one update Visual Studio.

larshg avatar Oct 19 '24 19:10 larshg

What about plus 10, just like https://github.com/PointCloudLibrary/pcl/pull/5463

WangWeiLin-MV avatar Oct 21 '24 04:10 WangWeiLin-MV

Just ping.

WangWeiLin-MV avatar Dec 24 '24 07:12 WangWeiLin-MV