pcl
pcl copied to clipboard
PointCloudLibrary
Update clang-tidy github action
You can see the error log on the azure site, if click on details and further. Ie https://github.com/PointCloudLibrary/pcl/actions/runs/10539455724/job/29203686331?pr=6116#step:4:4778
It seems the boolean expression can be simplified. Unfortunately I dont have time to figure out how exactly.
You can see the error log on the azure site, if click on details and further. Ie https://github.com/PointCloudLibrary/pcl/actions/runs/10539455724/job/29203686331?pr=6116#step:4:4778
It seems the boolean expression can be simplified. Unfortunately I dont have time to figure out how exactly.
Just had a look on my PC as well - there are quite a lot of changes required...
You can see the error log on the azure site, if click on details and further. Ie https://github.com/PointCloudLibrary/pcl/actions/runs/10539455724/job/29203686331?pr=6116#step:4:4778 It seems the boolean expression can be simplified. Unfortunately I dont have time to figure out how exactly.
Just had a look on my PC as well - there are quite a lot of changes required...
Yes, that's what I meant. To be precise, there are a total of 419 errors. I skimmed through the logs and found 5 types of errors overall.
-
error: use emplace instead of push [modernize-use-emplace,-warnings-as-errors]- only one error -
error: the 'empty' method should be used to check for emptiness instead of 'length' [readability-container-size-empty,-warnings-as-errors]- only one error -
error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]- 40 errors -
error: use emplace_back instead of push_back [modernize-use-emplace,-warnings-as-errors]- most of the errors (a total of 328) are of this type but will only require replacing keywords. -
error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]- 49 errors. This one might take a little more time to resolve since it requires figuring out how to simplify the expressions.
I'll try to make the necessary changes whenever possible, but it might take a few days to resolve all of them.
P.S. If I'm missing anything from the above list, please let me know.
When I search for: Error: it shows 100 entries from the log. Please make new Prs - maybe for each type of errors you listed. Or atleast one new PR, with ie. 5 commits with each type in each commit. That would make it easier to review 😄
When I search for: Error: it shows 100 entries from the log.
I believe the search only reports 100 matches at most, even if there are more
Please make new Prs - maybe for each type of errors you listed. Or atleast one new PR, with ie. 5 commits with each type in each commit. That would make it easier to review 😄
I second this: please make sure that the PR(s) don't become too large. It seems that some errors are reported multiple times, so hopefully there are many duplicates among the 419 reported errors. :slightly_smiling_face:
