pcl icon indicating copy to clipboard operation
pcl copied to clipboard

Modernized memset via uniform init or modern constructs

Open gnawme opened this issue 2 years ago • 2 comments

As a follow-up to #4299, modernized more memset usages by either employing uniform initialization or modern constructs

gnawme avatar Sep 18 '22 23:09 gnawme

@mvieth Would you consider it worthwhile to convert the many memset usages in opennurbs?

gnawme avatar Sep 18 '22 23:09 gnawme

@mvieth Would you consider it worthwhile to convert the many memset usages in opennurbs?

It would be great to get rid of all the compiler warnings (memset, ...) in opennurbs and other third-party code, but maybe we could check if we can replace the third-party code in the PCL repository with newer versions from upstream, where hopefully many code problems are fixed. We would have to check though whether licenses and code are compatible ...

mvieth avatar Sep 19 '22 18:09 mvieth

@mvieth Would you consider it worthwhile to convert the many memset usages in opennurbs?

It would be great to get rid of all the compiler warnings (memset, ...) in opennurbs and other third-party code, but maybe we could check if we can replace the third-party code in the PCL repository with newer versions from upstream, where hopefully many code problems are fixed. We would have to check though whether licenses and code are compatible ...

Current opennurbs is 2018, vs the 2012 version that is in PCL. Some of the PCL examples would have to be rewritten, but there appear to be only small tweaks to PCL code. Unfortunately, the 2018 version introduces a number of new compiler warnings of its own.

If you're curious, I put the changes (which don't build yet) in this branch: upstream/norm.evangelista/use-opennurbs-2018

gnawme avatar Sep 26 '22 17:09 gnawme