pcl
pcl copied to clipboard
no more typeid, it's constexpr
isSamePointType function
- is constexpr now
- uses type traits instead of typeid comparison correspondence estimation functions forward point selection to helper template functions specializations instead of if blocks with runtime type checks
@al-tu The new test(s) don't seem to compile yet
@kunaltyagi @mvieth hello! do you have any idea why one particular test on clang/macos catalina fails? may this be a flaky situation? it would be nice to be able to restart ci via bot command
@kunaltyagi @mvieth hello! do you have any idea why one particular test on clang/macos catalina fails? may this be a flaky situation? it would be nice to be able to restart ci via bot command
I restarted the CI. Unfortunately, there are a few tests that fail randomly (but rarely)
@kunaltyagi @mvieth hello! do you have any idea why one particular test on clang/macos catalina fails? may this be a flaky situation? it would be nice to be able to restart ci via bot command
I restarted the CI. Unfortunately, there are a few tests that fail randomly (but rarely)
thanks a lot! passes now, so yes, that was a random fail
hello. it's actually ready now, could you please re-review? thanks!
@al-tu Do you have time to rebase this?
@al-tu Do you have time to rebase this?
sure, done