pcl icon indicating copy to clipboard operation
pcl copied to clipboard

no more typeid, it's constexpr

Open al-tu opened this issue 4 years ago • 5 comments

isSamePointType function

  1. is constexpr now
  2. uses type traits instead of typeid comparison correspondence estimation functions forward point selection to helper template functions specializations instead of if blocks with runtime type checks

al-tu avatar Aug 17 '21 07:08 al-tu

@al-tu The new test(s) don't seem to compile yet

mvieth avatar Dec 23 '21 10:12 mvieth

@kunaltyagi @mvieth hello! do you have any idea why one particular test on clang/macos catalina fails? may this be a flaky situation? it would be nice to be able to restart ci via bot command

al-tu avatar Mar 13 '22 07:03 al-tu

@kunaltyagi @mvieth hello! do you have any idea why one particular test on clang/macos catalina fails? may this be a flaky situation? it would be nice to be able to restart ci via bot command

I restarted the CI. Unfortunately, there are a few tests that fail randomly (but rarely)

mvieth avatar Mar 13 '22 09:03 mvieth

@kunaltyagi @mvieth hello! do you have any idea why one particular test on clang/macos catalina fails? may this be a flaky situation? it would be nice to be able to restart ci via bot command

I restarted the CI. Unfortunately, there are a few tests that fail randomly (but rarely)

thanks a lot! passes now, so yes, that was a random fail

al-tu avatar Mar 13 '22 12:03 al-tu

hello. it's actually ready now, could you please re-review? thanks!

al-tu avatar Jun 07 '22 04:06 al-tu

@al-tu Do you have time to rebase this?

larshg avatar Oct 20 '22 19:10 larshg

@al-tu Do you have time to rebase this?

sure, done

al-tu avatar Oct 21 '22 20:10 al-tu