pcl icon indicating copy to clipboard operation
pcl copied to clipboard

[search] Convert "test" to benchmark

Open kunaltyagi opened this issue 4 years ago • 4 comments

This "test" doesn't really belong here?

It seems to capture processing times, but don't print or use them / compare them?

Originally posted by @larshg in https://github.com/PointCloudLibrary/pcl/pull/4712#discussion_r617306815

kunaltyagi avatar Apr 22 '21 06:04 kunaltyagi

For anyone interested: benchmarks are added now, you can orient yourself at the existing benchmark(s).

mvieth avatar Jun 30 '21 19:06 mvieth

Added a new label for the new module. Should have done that before :)

kunaltyagi avatar Jul 01 '21 06:07 kunaltyagi

Hey, @mvieth can I work on this issue? Or is this like also closed?

Zekrom-7780 avatar Jan 17 '22 18:01 Zekrom-7780

@Zekrom-7780 Yes, you can work on this issue. Thank you!

mvieth avatar Jan 17 '22 19:01 mvieth

@mvieth @kunaltyagi I AM SOO SORRY, for reaching THIS late, but is this Still open? If yes, then I would still like to work on it

Zekrom-7780 avatar Oct 16 '23 16:10 Zekrom-7780

@Zekrom-7780 Sure, go ahead.

mvieth avatar Oct 17 '23 07:10 mvieth

@mvieth , I finished setting up the repo, and I saw like an entire test folder, and a benchmarks folder. Could you tell me on how to proceed with this?

So sorry if this is a dumb question

Zekrom-7780 avatar Oct 18 '23 12:10 Zekrom-7780

The goal is to convert this test: https://github.com/PointCloudLibrary/pcl/blob/e8ed4be802f7d0b1acff2f8b01d7c5f381190e05/test/search/test_organized_index.cpp#L359 to a proper benchmark (like the other benchmarks in the benchmarks folder). Notice how the test measures the time needed by setInputCloud and radiusSearch. The brute force search that is also performed in the test is pretty much useless and can be discarded.

mvieth avatar Oct 19 '23 08:10 mvieth

Thanks for the explanation @mvieth , I have made a pull request, could you please look into it?

Also, please could you tell me on how to get the build checks to pass, like which script do I have to run?

Also, as mentioned in the pull request, Soo Sorry that I wasn't able to rebase the multiple commits into a single one

Zekrom-7780 avatar Oct 19 '23 21:10 Zekrom-7780

Fixed by #5851

larshg avatar Nov 25 '23 12:11 larshg