pcl icon indicating copy to clipboard operation
pcl copied to clipboard

Add Dockerfile (and image) for clang-tidy CI

Open kunaltyagi opened this issue 4 years ago • 3 comments

Image can be based off the pointcloudlibrary/env and add it and clang-tidy (version dependent on the github workflow)

IIRC, doesn't clang-tidy require all dependencies to be installed?

Ahh, that might be. I'm not that familiar with clang/tidy.

I can see Cmake is run as well, which will fail with missing dependencies.

Originally posted by @larshg in https://github.com/PointCloudLibrary/pcl/pull/4636#issuecomment-795061118

kunaltyagi avatar Mar 10 '21 11:03 kunaltyagi

Hello @kunaltyagi, Could you please give more information i.e similar example or documenation links?

theoniko avatar Dec 17 '21 19:12 theoniko

We want to enable clang-tidy in the CI for formatting. The env dockerfile is only items required for building PCL.

So, we want to:

  • create a new dockerfile, which extend all the env, adding clang-tidy
  • add it in the docker CI to keep them updated

In future, we would want to switch on clang-tidy either pre-build or post-format (since clang-tidy is impacted by build flags, and we have quite a matrix of build flags)

kunaltyagi avatar Dec 18 '21 04:12 kunaltyagi

I have used clang tidy (https://clang.llvm.org/extra/clang-tidy/) in the past. More specifically, the checks and automated fixes that it offers. Your idea is to be used only for code formatting only right?

theoniko avatar Jan 07 '22 19:01 theoniko