pcl
pcl copied to clipboard
[common] Add `bool`, `std::{u}int64_t` as possible point field types
Closes #1153, closes #2565
io/src/ply_io.cpp uses int in both sizeof and test output. Adding int64 there would need discussion (or is unneeded). Also needed: feedback on tests: test/io/test_io.cpp
@mvieth Could you review this please?
Resolved conflict
I'm a bit with @mvieth about the bool comparison - do we have unit test that covers the new types?
I think adding tests for the new field types to test/io/test_io.cpp would be a good first step.
@mvieth I want to add a warning that IO for boolean type might result in errors and require manual editing of header to work. What do you think would be the best approach: Documentation or warning on io?