pcl icon indicating copy to clipboard operation
pcl copied to clipboard

[common] Add `bool`, `std::{u}int64_t` as possible point field types

Open kunaltyagi opened this issue 5 years ago • 6 comments

Closes #1153, closes #2565

kunaltyagi avatar May 21 '20 05:05 kunaltyagi

io/src/ply_io.cpp uses int in both sizeof and test output. Adding int64 there would need discussion (or is unneeded). Also needed: feedback on tests: test/io/test_io.cpp

kunaltyagi avatar May 21 '20 05:05 kunaltyagi

@mvieth Could you review this please?

kunaltyagi avatar Sep 06 '20 14:09 kunaltyagi

Resolved conflict

kunaltyagi avatar Nov 17 '20 05:11 kunaltyagi

I'm a bit with @mvieth about the bool comparison - do we have unit test that covers the new types?

larshg avatar Nov 17 '20 06:11 larshg

I think adding tests for the new field types to test/io/test_io.cpp would be a good first step.

mvieth avatar Nov 17 '20 15:11 mvieth

@mvieth I want to add a warning that IO for boolean type might result in errors and require manual editing of header to work. What do you think would be the best approach: Documentation or warning on io?

kunaltyagi avatar Mar 14 '21 04:03 kunaltyagi