pcl icon indicating copy to clipboard operation
pcl copied to clipboard

[Style guide] Update include section

Open larshg opened this issue 5 years ago • 5 comments
trafficstars

Update the include section, with the correct order of includes and add a comment about why its included.

larshg avatar Mar 19 '20 18:03 larshg

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

stale[bot] avatar May 19 '20 06:05 stale[bot]

I think this can be closed. I remember an addition to the style guide, but can't link the PR yet.

kunaltyagi avatar May 19 '20 10:05 kunaltyagi

#4020 Solved this one :+1:

Well, somewhat. We are missing why are it included.

larshg avatar May 19 '20 11:05 larshg

Could you expand a bit (or go ahead with a PR 😆 )?

kunaltyagi avatar May 19 '20 11:05 kunaltyagi

@larshg Do you have time/do you want to create a pull request to close this issue? You probably mean something like this?

#include <pcl/common/common.h> // for getMinMax3D
#include <pcl/pcl_macros.h> // for PCL_DEPRECATED

mvieth avatar Jan 16 '22 19:01 mvieth