csp icon indicating copy to clipboard operation
csp copied to clipboard

Add support for Numpy 2.0

Open ngoldbaum opened this issue 1 year ago • 1 comments

__________________________ TestNumpyAdapter.test_int ___________________________

self = <csp.tests.adapters.test_numpy.TestNumpyAdapter testMethod=test_int>

    def test_int(self):
        raw_vals = [7, -13, 21]
        res = csp.run(g, typ=int, values=np.array(raw_vals), dts=test_dts_ndarray, starttime=test_starttime)
        self.assertEqual(res["out"], list(zip(test_dts, raw_vals)))
    
        for dtype in ("b", "h", "i", "l", "object"):
            res = csp.run(
                g, typ=int, values=np.array(raw_vals, dtype=dtype), dts=test_dts_ndarray, starttime=test_starttime
            )
>           self.assertEqual(res["out"], list(zip(test_dts, raw_vals)))
E           AssertionError: Lists differ: [(dat[61 chars], 1, 2, 1, 0), 243), (datetime.datetime(2000, 1, 2, 2, 0), 21)] != [(dat[61 chars], 1, 2, 1, 0), -13), (datetime.datetime(2000, 1, 2, 2, 0), 21)]
E           
E           First differing element 1:
E           (datetime.datetime(2000, 1, 2, 1, 0), 243)
E           (datetime.datetime(2000, 1, 2, 1, 0), -13)
E           
E             [(datetime.datetime(2000, 1, 1, 1, 0), 7),
E           -  (datetime.datetime(2000, 1, 2, 1, 0), 243),
E           ?                                        ^^
E           
E           +  (datetime.datetime(2000, 1, 2, 1, 0), -13),
E           ?                                        ^^
E           
E              (datetime.datetime(2000, 1, 2, 2, 0), 21)]

csp/tests/adapters/test_numpy.py:34: AssertionError

Not sure exactly what change in numpy caused this. I'm a numpy maintainer and am happy to try to look more closely at this if you'd like me to.

ngoldbaum avatar Feb 09 '24 22:02 ngoldbaum

We probably won't support numpy 2 for some time

timkpaine avatar Feb 10 '24 01:02 timkpaine